fix: remove unused ElementMetadata.section
#2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scanny
force-pushed
the
scanny/remove-metadata-section-field
branch
from
0145311
to
0804f9b
Compare
scanny
force-pushed
the
scanny/remove-metadata-section-field
branch
from
0804f9b
to
d64f3f1
Compare
The `.section` field in `ElementMetadata` is dead-code, being left from a prior attempt a partitioning EPUB documents. It is no longer used. Remove it and any code that uses it.
scanny
force-pushed
the
scanny/remove-metadata-section-field
branch
from
d64f3f1
to
d737f05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
.sectionfield inElementMetadatais dead code, possibly a remainder from a prior iteration ofpartition_epub(). In any case, it is not populated by any partitioner. Remove it and any code that uses it.