rfctr(pptx): make PptxPartitionerOptions public #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the leading underscore because client code that implements a custom shape subpartitioner will need to reference this class.
scanny
force-pushed
the
scanny/prep-pptx-image-odds-and-ends
branch
from
b21111a
to
07f9996
Compare
|
Tagging #2903, which this PR works towards address |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A few additional small, mechanical odds and ends required for PPTX image extraction.
The big one is removing the leading underscore from
PptxPartitionerOptionsbecause now client code that implements a custom Picture-shape sub-partitioner will need to reference this class.