bug: Add options to SFTP #2843
Merged
bug: Add options to SFTP #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmetmeleq
reviewed
Apr 3, 2024
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ | |||
| ### Fixes | |||
|
|
|||
| * **Fix `partition_html()` swallowing some paragraphs**. The `partition_html()` only considers elements with limited depth to avoid becoming the text representation of a giant div. This fix increases the limit value. | |||
| * **Fix SFTP** Adds more options to prevent looking for ssh files if only using username password. | |||
There was a problem hiding this comment.
Suggested change
| * **Fix SFTP** Adds more options to prevent looking for ssh files if only using username password. | |
| * **Fix SFTP** Adds flag options to SFTP connector on whether to use ssh keys / agent, with flag values defaulting to False. This is to prevent looking for ssh files when using username and password. Currently, username and password are required, making that always the case. |
LGTM |
ahmetmeleq
approved these changes
Apr 3, 2024
kaaloo
pushed a commit
to inclusif/unstructured
that referenced
this pull request
Apr 8, 2024
Noticed authentication errors when connected to a non localhost SFTP. It errored out when looking for ssh keys. This gives us the option to not look for those. Which is correct if we are giving it user/password.
kaaloo
pushed a commit
to inclusif/unstructured
that referenced
this pull request
Apr 8, 2024
Noticed authentication errors when connected to a non localhost SFTP. It errored out when looking for ssh keys. This gives us the option to not look for those. Which is correct if we are giving it user/password.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed authentication errors when connected to a non localhost SFTP. It errored out when looking for ssh keys.
This gives us the option to not look for those. Which is correct if we are giving it user/password.