Roman/bugfix support bedrock embeddings #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did you get changes in expected output when running the comparison test in the .sh? My embeddings are now 8 decimals instead of 17 decimals. |
rbiseck3
force-pushed
the
roman/bugfix-support-bedrock-embeddings
branch
from
2f2a710
to
3f13302
Compare
|
Would love to see this running in test_ingest_src. Can you fix the lint and shfmt. |
rbiseck3
force-pushed
the
roman/bugfix-support-bedrock-embeddings
branch
from
3f13302
to
b078113
Compare
|
test_ingest_src failed in CI |
CI needs to have updated AWS creds to have permissions to hit the bedrock model. |
did you want to give us-east-2 a try for the region? locally I'm able to run bedrock on both local |
rbiseck3
force-pushed
the
roman/bugfix-support-bedrock-embeddings
branch
from
d5f47dc
to
597e6c2
Compare
#2671) This pull request includes updated ingest test fixtures. Please review and merge if appropriate. Co-authored-by: rbiseck3 <rbiseck3@users.noreply.github.com>
rbiseck3
force-pushed
the
roman/bugfix-support-bedrock-embeddings
branch
from
5968ad7
to
f9c41ff
Compare
kaaloo
pushed a commit
to inclusif/unstructured
that referenced
this pull request
Apr 8, 2024
### Description This PR resolved the following open issue: [bug/bedrock-encoder-not-supported-in-ingest](https://github.com/Unstructured-IO/unstructured/issues/2319). To do so, the following changes were made: * All aws configs were added as input parameters to the CLI * These were mapped to the bedrock embedder when an embedder is generated via `get_embedder` * An ingest test was added to call the aws bedrock service * Requirements for boto were bumped because the first version to introduce the bedrock runtime, which is required to hit the bedrock service, was introduced in version `1.34.63`, which was ahead of the version of boto pinned. --------- Co-authored-by: ryannikolaidis <1208590+ryannikolaidis@users.noreply.github.com> Co-authored-by: rbiseck3 <rbiseck3@users.noreply.github.com>
kaaloo
pushed a commit
to inclusif/unstructured
that referenced
this pull request
Apr 8, 2024
### Description This PR resolved the following open issue: [bug/bedrock-encoder-not-supported-in-ingest](https://github.com/Unstructured-IO/unstructured/issues/2319). To do so, the following changes were made: * All aws configs were added as input parameters to the CLI * These were mapped to the bedrock embedder when an embedder is generated via `get_embedder` * An ingest test was added to call the aws bedrock service * Requirements for boto were bumped because the first version to introduce the bedrock runtime, which is required to hit the bedrock service, was introduced in version `1.34.63`, which was ahead of the version of boto pinned. --------- Co-authored-by: ryannikolaidis <1208590+ryannikolaidis@users.noreply.github.com> Co-authored-by: rbiseck3 <rbiseck3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolved the following open issue: bug/bedrock-encoder-not-supported-in-ingest. To do so, the following changes were made:
get_embedder1.34.63, which was ahead of the version of boto pinned.