Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated workaround specifying package requirements #87

Open
canrager opened this issue Mar 29, 2024 · 1 comment · May be fixed by #89
Open

Remove outdated workaround specifying package requirements #87

canrager opened this issue Mar 29, 2024 · 1 comment · May be fixed by #89

Comments

@canrager
Copy link

https://github.com/alan-cooney/CircuitsVis/blob/c264c944204f955245209019376190f0d9242516/python/pyproject.toml#L34

...introduced a bug-fix for compatibility with pytorch 2.1. . This breaks compatibility with pytorch 2.2. Could you remove the bugfix? See error message:

ERROR: Cannot install -r requirements.txt (line 1) and -r requirements.txt (line 8) because these package versions have conflicting dependencies.

The conflict is caused by:
    circuitsvis 1.43.2 depends on nvidia-nccl-cu12==2.18.1; platform_system == "Linux" and platform_machine == "x86_64"
    torch 2.2.2 depends on nvidia-nccl-cu12==2.19.3; platform_system == "Linux" and platform_machine == "x86_64"
    circuitsvis 1.43.2 depends on nvidia-nccl-cu12==2.18.1; platform_system == "Linux" and platform_machine == "x86_64"
    torch 2.2.1 depends on nvidia-nccl-cu12==2.19.3; platform_system == "Linux" and platform_machine == "x86_64"
    circuitsvis 1.43.2 depends on nvidia-nccl-cu12==2.18.1; platform_system == "Linux" and platform_machine == "x86_64"
    torch 2.2.0 depends on nvidia-nccl-cu12==2.19.3; platform_system == "Linux" and platform_machine == "x86_64"
@alan-cooney
Copy link
Collaborator

Happy to accept a PR on this if you're able to make one?

quinn-dougherty added a commit to quinn-dougherty/CircuitsVis that referenced this issue Apr 9, 2024
quinn-dougherty added a commit to quinn-dougherty/CircuitsVis that referenced this issue Apr 9, 2024
@quinn-dougherty quinn-dougherty linked a pull request Apr 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants