Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcd_of_n_numbers #8057

Merged
merged 24 commits into from
Jan 10, 2023
Merged

gcd_of_n_numbers #8057

merged 24 commits into from
Jan 10, 2023

Conversation

balakhaniyan
Copy link
Contributor

Describe your change:

Greatest common divisor for n numbers

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label Dec 27, 2022
cclauss
cclauss reviewed Dec 27, 2022
View reviewed changes
maths/gcd_of_n_numbers.py Outdated
Comment on lines 29 to 31
if factors is None:
# first call of get factors and so there are no founded factors
factors = Counter()
Copy link
Member

@cclauss cclauss Dec 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All falsey values are as dangerous as None.

Suggested change
if factors is None:
# first call of get factors and so there are no founded factors
factors = Counter()
factors = factors or Counter()

cclauss
cclauss reviewed Dec 27, 2022
View reviewed changes
maths/gcd_of_n_numbers.py Outdated
return factors

if number % factor > 0:
# if it is grater than zero
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# if it is grater than zero
# if it is greater than zero

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, updated... please check and let me know if there are any problems

algorithms-keeper[bot]
algorithms-keeper bot reviewed Dec 27, 2022
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

maths/gcd_of_n_numbers.py Show resolved Hide resolved
algorithms-keeper[bot]
algorithms-keeper bot reviewed Dec 27, 2022
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

maths/gcd_of_n_numbers.py Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot added the tests are failing Do not merge until tests pass label Dec 27, 2022
algorithms-keeper[bot]
algorithms-keeper bot reviewed Dec 27, 2022
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

maths/gcd_of_n_numbers.py Show resolved Hide resolved
@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Dec 27, 2022
@dhruvmanila
Copy link
Member

@algorithms-keeper review

cclauss
cclauss reviewed Jan 10, 2023
View reviewed changes
maths/gcd_of_n_numbers.py Outdated

same_factors: Counter = data[0]
for d in data[1:]:
same_factors = same_factors & d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
same_factors = same_factors & d
same_factors &= d

@algorithms-keeper algorithms-keeper bot added require descriptive names This PR needs descriptive function and/or variable names tests are failing Do not merge until tests pass labels Jan 10, 2023
algorithms-keeper[bot]
algorithms-keeper bot reviewed Jan 10, 2023
View reviewed changes
Copy link

@algorithms-keeper algorithms-keeper bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

maths/gcd_of_n_numbers.py Outdated
# now, same_factors is something like {2: 2, 3: 4} that means 2 * 2 * 3 * 3 * 3 * 3
# power each factor and multiply
# for {2: 2, 3: 4}, it is [4, 81] and then 324
return reduce(lambda x, y: x * y, (factor ** power for factor, power in same_factors.items()), 1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide descriptive name for the parameter: x

Please provide descriptive name for the parameter: y

@algorithms-keeper algorithms-keeper bot removed the tests are failing Do not merge until tests pass label Jan 10, 2023
cclauss
cclauss requested changes Jan 10, 2023
View reviewed changes
maths/gcd_of_n_numbers.py
@@ -87,23 +88,19 @@ def get_greatest_common_divisor(*numbers: int) -> int:

# we just need factors, not numbers itself
try:
data = [get_factors(number) for number in numbers]
same_factors, *factors = map(get_factors, numbers)
Copy link
Member

@cclauss cclauss Jan 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/TheAlgorithms/Python/blob/master/CONTRIBUTING.md#coding-style

List comprehensions and generators are preferred over the use of lambda, map, filter, reduce

https://docs.python.org/3/whatsnew/3.0.html#views-and-iterators-instead-of-lists

maths/gcd_of_n_numbers.py Outdated
for m in [factor ** same_factors[factor] for factor in same_factors]:
mult *= m
return mult
return reduce(lambda x, y: x * y, (factor ** power for factor, power in same_factors.items()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be hard to understand and maintain.

@algorithms-keeper algorithms-keeper bot added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Jan 10, 2023
@algorithms-keeper algorithms-keeper bot added awaiting reviews This PR is ready to be reviewed and removed require descriptive names This PR needs descriptive function and/or variable names awaiting changes A maintainer has requested changes to this PR labels Jan 10, 2023
cclauss
cclauss approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!!

@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Jan 10, 2023
@cclauss cclauss merged commit 1a27258 into TheAlgorithms:master Jan 10, 2023
Cjkjvfnby pushed a commit to Cjkjvfnby/Python that referenced this pull request Mar 13, 2023
@balakhaniyan @pre-commit-ci @Cjkjvfnby
gcd_of_n_numbers (TheAlgorithms#8057)
6fb38f0 
* add maths/Gcd of N Numbers

* add maths/Gcd of N Numbers

* add maths/Gcd of N Numbers

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add maths/Gcd of N Numbers

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add maths/Gcd of N Numbers

* add maths/Gcd of N Numbers

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* add maths/Gcd of N Numbers

* add maths/Gcd of N Numbers

* more pythonic

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* more pythonic

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* merged

* merged

* more readable

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila left review comments

@realstealthninja realstealthninja realstealthninja left review comments

@algorithms-keeper algorithms-keeper algorithms-keeper left review comments

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balakhaniyan @dhruvmanila @cclauss @realstealthninja