Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypy] Fix type annotations in data_structures/queue/circular_queue_linked_list.py #5749

Merged
merged 2 commits into from
Nov 2, 2021
Merged

[mypy] Fix type annotations in data_structures/queue/circular_queue_linked_list.py #5749

merged 2 commits into from
Nov 2, 2021

Conversation

dylanbuchi
Copy link
Contributor

@dylanbuchi dylanbuchi commented Nov 2, 2021 •
edited
Loading

Describe your change:

Related issue: #4052

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Nov 2, 2021
cclauss
cclauss approved these changes Nov 2, 2021
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add 10 blank lines?

data_structures/queue/circular_queue_linked_list.py Outdated Show resolved Hide resolved
data_structures/queue/circular_queue_linked_list.py Outdated Show resolved Hide resolved
data_structures/queue/circular_queue_linked_list.py Outdated Show resolved Hide resolved
data_structures/queue/circular_queue_linked_list.py Outdated Show resolved Hide resolved
data_structures/queue/circular_queue_linked_list.py Outdated Show resolved Hide resolved
data_structures/queue/circular_queue_linked_list.py Outdated Show resolved Hide resolved
data_structures/queue/circular_queue_linked_list.py Outdated Show resolved Hide resolved
data_structures/queue/circular_queue_linked_list.py Outdated Show resolved Hide resolved
data_structures/queue/circular_queue_linked_list.py Outdated Show resolved Hide resolved
data_structures/queue/circular_queue_linked_list.py Outdated Show resolved Hide resolved
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 2, 2021
@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Nov 2, 2021
@cclauss cclauss merged commit 24731b0 into TheAlgorithms:master Nov 2, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Nov 2, 2021
@dylanbuchi dylanbuchi changed the title [mypy] fix type annotations in data_structures/queue/circular_queue_linked_list.py [mypy] Fix type annotations in data_structures/queue/circular_queue_linked_list.py Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
enhancement This PR modified some existing files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanbuchi @cclauss