Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

current_weather, weather_forecast, weather_onecall #2048

Merged
merged 3 commits into from
May 30, 2020
Merged

current_weather, weather_forecast, weather_onecall #2048

merged 3 commits into from
May 30, 2020

Conversation

cclauss
Copy link
Member

@cclauss cclauss commented May 30, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@cclauss
Copy link
Member Author

cclauss commented May 30, 2020

@swapnanildutta Your review please.

swapnanildutta
swapnanildutta approved these changes May 30, 2020
View reviewed changes
DIRECTORY.md
@@ -641,6 +641,7 @@
## Web Programming
* [Crawl Google Results](https://github.com/TheAlgorithms/Python/blob/master/web_programming/crawl_google_results.py)
* [Current Stock Price](https://github.com/TheAlgorithms/Python/blob/master/web_programming/current_stock_price.py)
* [Current Weather](https://github.com/TheAlgorithms/Python/blob/master/web_programming/current_weather.py)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's Perfect

Copy link
Member Author

@cclauss cclauss May 30, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change was made automatically by a GitHub Action
https://github.com/TheAlgorithms/Python/blob/master/.github/workflows/directory_writer.yml#L15 -->
https://github.com/TheAlgorithms/Python/blob/master/scripts/build_directory_md.py

swapnanildutta
swapnanildutta approved these changes May 30, 2020
View reviewed changes
Copy link
Contributor

@swapnanildutta swapnanildutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even Better

@onlinejudge95 onlinejudge95 merged commit fa358d6 into master May 30, 2020
@cclauss cclauss deleted the weather_onecall branch May 30, 2020 18:37
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@cclauss @stokhos
current_weather, weather_forecast, weather_onecall (TheAlgorithms#2048)
2947dcd 
* current_weather, weather_forecast, weather_onecall

* updating DIRECTORY.md

* weather_forecast("Kolkata, India")

Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onlinejudge95 onlinejudge95 onlinejudge95 approved these changes

@swapnanildutta swapnanildutta swapnanildutta approved these changes

Assignees

@AnupKumarPanwar AnupKumarPanwar

@harshildarji harshildarji

@poyea poyea

@onlinejudge95 onlinejudge95

@deadshotsb deadshotsb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cclauss @onlinejudge95 @swapnanildutta @AnupKumarPanwar @harshildarji @poyea @deadshotsb