Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data_structures/linked_list: Add __len__() function and tests #2047

Merged
merged 15 commits into from
May 31, 2020
Merged

data_structures/linked_list: Add __len__() function and tests #2047

merged 15 commits into from
May 31, 2020

Conversation

Lakshmikanth2001
Copy link
Contributor

@Lakshmikanth2001 Lakshmikanth2001 commented May 30, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

cclauss
cclauss reviewed May 30, 2020
View reviewed changes
maths/prime_check.py Outdated Show resolved Hide resolved
cclauss
cclauss reviewed May 30, 2020
View reviewed changes
maths/prime_check.py Outdated Show resolved Hide resolved
@cclauss cclauss changed the title Lakshmikanth2001 patch 3 data_structures/linked_list: Add __len__() function and tests May 31, 2020
cclauss
cclauss approved these changes May 31, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution.

@cclauss cclauss merged commit 321b142 into TheAlgorithms:master May 31, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@Lakshmikanth2001 @cclauss @stokhos
data_structures/linked_list: Add __len__() function and tests (TheAlg…
54fbcd0 
…orithms#2047)

* Update __init__.py

please add a function to get length of linked list

* Update __init__.py

* Update doubly_linked_list.py

all size function lo doubly linked list class

* prime number _better method

* comments

* Updated init.py 2

made it more pythonic

* updated length function

* commnet in linked_list construtor

* Update data_structures/linked_list/__init__.py

accepecting changes

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update data_structures/linked_list/__init__.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* Update __init__.py

* Revert changes to doubly_linked_list.py

* Revert changes to prime_check.py

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lakshmikanth2001 @cclauss