Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update is_palindrome.py #2025

Merged
merged 3 commits into from
May 22, 2020
Merged

Update is_palindrome.py #2025

merged 3 commits into from
May 22, 2020

Conversation

ashwindasr
Copy link
Contributor

  1. Added Type Hints to improve readability.
  2. Improved existing algorithm to include more cases
  3. Added more doctests.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

cclauss
cclauss reviewed May 22, 2020
View reviewed changes
strings/is_palindrome.py Outdated Show resolved Hide resolved
@cclauss cclauss merged commit d8a4faf into TheAlgorithms:master May 22, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@ashwindasr @cclauss @stokhos
Update is_palindrome.py (TheAlgorithms#2025)
b024abc 
* Update is_palindrome.py

* Update is_palindrome.py

* Reuse s

Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashwindasr @cclauss