Make it possible to queue up diag for the context #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #1004 This adds a system for queuing diag messages that will be attached to the next context that releases, upon release the diags will be issued so long as the context caused at least 1 failure. The diags will be disgarded if the context did not add any failures. the `no_warnings` and `lives` tools both now automatically add the warning/exception to the diag queue. Examples: This will add the warning as a diagnostics message ok(no_warnings { warn "xxx" }, "Did not get any warnings"); This will not add the warning-diag as no failures are caused ok(!no_warnings { warn "xxx" }, "Got warnings"); This will add the exception as a diagnostics message ok(lives { die "XXX" }, "Did not die"); This will not add the exception as a diagnostics message ok(!lives { die "XXX" }, "Died");
exodist
force-pushed
the
1004_warnings_diag
branch
from
0f7b54e
to
5b12439
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1004
This adds a system for queuing diag messages that will be attached to the next context that releases, upon release the diags will be issued so long as the context caused at least 1 failure. The diags will be disgarded if the context did not add any failures.
the
no_warningsandlivestools both now automatically add the warning/exception to the diag queue.Examples:
This will add the warning as a diagnostics message ok(no_warnings { warn "xxx" }, "Did not get any warnings");
This will not add the warning-diag as no failures are caused ok(!no_warnings { warn "xxx" }, "Got warnings");
This will add the exception as a diagnostics message ok(lives { die "XXX" }, "Did not die");
This will not add the exception as a diagnostics message ok(!lives { die "XXX" }, "Died");