Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: component field visibility public #14

Merged
merged 1 commit into from
Jan 7, 2024
Merged

refactor: component field visibility public #14

merged 1 commit into from
Jan 7, 2024

Conversation

jdrueckert
Copy link
Member

Newer Java versions are stricter with regards to access restrictions when using reflection.
This affects in particular the serialization of non-public fields in our component classes.
For this reason, we decided to exclude non-public component fields from serialization and refactor all non-public component fields to be public instead to ensure not breaking any game and especially saving/loading behavior.

A future module overhaul may have a more detailed look into the components and make considerate decisions to use non-public fields.

Relates to MovingBlocks/Terasology#5191

@jdrueckert jdrueckert added Size: S Small effort likely only affecting a single area and requiring little to no research Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity labels Dec 5, 2023
soloturn
soloturn approved these changes Dec 13, 2023
View reviewed changes
Copy link

@soloturn soloturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does not mark it as reviewed.

@jdrueckert jdrueckert merged commit aa2b625 into develop Jan 7, 2024
12 checks passed
@jdrueckert jdrueckert deleted the refactor/component-field-visibility-public branch January 7, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soloturn soloturn soloturn approved these changes

@skaldarnar skaldarnar skaldarnar approved these changes

Assignees
No one assigned
Labels
Size: S Small effort likely only affecting a single area and requiring little to no research Topic: Stabilization Requests, Issues and Changes related to improving stablity and reducing flakyness Type: Refactoring Request for or implementation of pure and automatic refactorings, e.g. renaming, to improve clarity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdrueckert @soloturn @skaldarnar