Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin/bk-response-check): change prometheus label path to matched_uri, decrease the metrics #8

Merged

Conversation

wklken
Copy link
Collaborator

@wklken wklken commented Jun 14, 2023

将 path 换成 matched_uri, 减少metrics数量(统计视图中只用到了route_id/route_name, 不会用到path)

  • 原来 path="/api/httpbin/prod/status/200/" (500/404等等)
  • 改为 matched_uri="/api/httpbin/prod/status/:codes/?"

Copy link
Member

@Han-Ya-Jun Han-Ya-Jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@piglei piglei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wklken wklken requested review from zhu327 and alex-smile June 25, 2023 12:08
@wklken wklken merged commit 65ba16c into TencentBlueKing:master Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants