Dev into master #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
lucifer/Errors.py
Outdated
| notifier.notify(err) | ||
| print("The Following Error Occurred In Current Module, Reported To Devs...\n"+str(err)) | ||
|
|
||
|
|
lucifer/GUI/GUI.py
Outdated
| "To Fix this problem please delete or edit the 'settings.yml' file!") | ||
| else: | ||
| Settings.create_settings(self.font) | ||
|
|
|
Issues
======
- Added 6
Complexity increasing per file
==============================
- lucifer/Requirements.py 8
- lucifer/Errors.py 2
- lucifer/Settings.py 4
See the complete overview on Codacy |
Skiller9090
commented
Sep 21, 2020
lucifer/Settings.py
Outdated
| if settings: | ||
| try: | ||
| return reduce(operator.getitem, setting_split, settings) | ||
| except KeyError as e: |
There was a problem hiding this comment.
Codacy found an issue: local variable 'e' is assigned to but never used (F841)
Skiller9090
commented
Sep 21, 2020
lucifer/Settings.py
Outdated
| return reduce(operator.getitem, setting_split, settings) | ||
| except KeyError as e: | ||
| raise LuciferSettingNotFound(setting) | ||
| except TypeError as e: |
There was a problem hiding this comment.
Codacy found an issue: local variable 'e' is assigned to but never used (F841)
Skiller9090
commented
Sep 21, 2020
lucifer/Settings.py
Outdated
| if settings: | ||
| try: | ||
| return reduce(operator.getitem, setting_split, settings) | ||
| except KeyError as e: |
There was a problem hiding this comment.
Codacy found an issue: Unused variable 'e'
Skiller9090
commented
Sep 21, 2020
| @@ -0,0 +1 @@ | |||
| luciferManager = None | |||
There was a problem hiding this comment.
Codacy found an issue: Missing docstring in public package (D104)
Skiller9090
commented
Sep 21, 2020
lucifer/GUI/Console.py
Outdated
| tags.append("stdout") | ||
| else: | ||
| tags.append(mapped_tag) | ||
| return *tags, |
There was a problem hiding this comment.
Codacy found an issue: invalid syntax (F999)
|
Code Climate has analyzed commit 53ecffd and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings changes (yml)