Upgrade stylelint-polaris to stylelint v16
#12337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
|
🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/polaris-migrator": "0.0.0-snapshot-20240705202418",
"@shopify/stylelint-polaris": "0.0.0-snapshot-20240705202418" |
aaronccasanova
requested review from
jesstelford,
kyledurand,
sam-b-rose and
alex-page
alex-page
approved these changes
Jul 7, 2024
sam-b-rose
approved these changes
Jul 8, 2024
kyledurand
approved these changes
Jul 8, 2024
Comment on lines
+12
to
+15
| 'selector-max-class': 5, | ||
| 'selector-max-combinators': 5, | ||
| 'selector-max-compound-selectors': 5, | ||
| 'selector-max-specificity': '0,5,0', |
There was a problem hiding this comment.
I'm concerned about these changes but I understand the need to ship this PR and how difficult it would be to refactor the css to make these tests pass. @jesstelford did you try just block disabling the rules here? Would that be possible?
…`stylelint-scss`
…it from 0,2,0 to 0,5,0
It is not forwards compatible with new CSS features. See: stylelint/stylelint#7630
…ing limit from 3 to 5
Co-authored-by: Kyle Durand <kyle.durand@shopify.com>
aaronccasanova
force-pushed
the
upgrade-stylelint-polaris
branch
from
7f13243
to
c003716
Compare
|
/snapit |
|
🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm. Test the snapshots by updating your "@shopify/polaris-migrator": "0.0.0-snapshot-20240708173140",
"@shopify/stylelint-polaris": "0.0.0-snapshot-20240708173140" |
Closed
jesstelford
added a commit
that referenced
this pull request
Jul 9, 2024
This reverts commit b2d2da4.
jesstelford
added a commit
that referenced
this pull request
Jul 9, 2024
This reverts commit b2d2da4.
This was referenced Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
This PR upgrades
stylelint-polaristostylelintv16 and drops support for v15 and v16.As part of this upgrade, the following updates were made:
stylelintto^16.6.1stylelint-scssto^6.3.2@shopify/eslint-pluginto^45.0.0@shopify/stylelint-pluginto^14.0.0eslintto^8.56.0jest-preset-stylelintto^7.0.1prettierto^3.2.2stylelintto report errors on async rules. See Stylelint issue for more details: Fixstylelint.utils.checkAgainstRule()for Promise-based rules stylelint/stylelint#7820--experimental-vm-modulesflag tojestcalls to enable support for async pluginsstylelint-polarisplugins andstylelintAPIs to be asynchronousprettier.formatcalls to be asynchronouseslintandstylelintfailures after dependency upgradesstyles-insert-stylelint-disablemigration asresult.messagesnodes are now detached from therootAST. Calls such asnode.prev()andnode.before(comment)now throw exceptions as the reported nodes don't have access to properties and methods previously exposed. The consensus speaking with @kyledurand and @sophschneider is that we can revisit adding support for this migration if and when it is needed again.How to 🎩
🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines
🎩 checklist
README.mdwith documentation changes