[Enhancement] Update seed_phrase_to_qr.py; warnings, add Compact SeedQR #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, tested without issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tools/seed_phrase_to_qr.py utility script converts a mnemonic to a digital SeedQR in png format. The tool is only meant for dev testing purposes and should announce itself as such if someone tries to run it.
Also adds support for generating Compact SeedQR format.
Changes mnemonic input to use interactive input steps rather than including the mnemonic when executing from the command line (minor improvement to not have mnemonics in your bash history, though, again, only disposable test seeds should be used here).
This pull request is categorized as a:
Checklist
If you modified or added functionality/workflow, did you add new unit tests?
I have tested this PR on the following platforms/os:
Meant to run in local dev environment, not on Raspi.