unittests for new settings defaults: msg-signing/qr-brightness-tips #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test in general feels just barely useful enough to offset its DRY offenses, but that's not a critique of this PR. Since the test is there, ya, let's at least update it to the current settings options. But maybe a simpler test (in a later PR) that just spot-checks different types of defaults would be sufficient going forward. ACK tested. |
|
ACK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 unit-tests for new settings defaults in 0.7.0.
The tests/test_controller.py tests all settings defaults as its last test. It's extra maintenance, but it's also helpful for us not to accidentally change defaults without also updating the unit-test, also helpful for keeping settings-generator in line with seedsigner settings defaults.