[bugfix] Reset state upon reading an invalid QR #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdmukai
changed the title
|
As of 3a3ac12 ACK tested |
|
ACK tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #456
The problem
The BackStack and the
Controller.resume_main_flowcan create some confusing debugging when an error happens mid-flow.In this case it was:
That would route you to the ErrorView which would then take you BACK, which routes you to SeedOptionsView. That detected the
Controller.resume_main_flowwhich then routes toSeedSignMessageConfirmMessageViewwhich assumes by that point that all necessary data has been loaded, yielding a second error screen.The fix
Don't attempt any kind of resumption of flow when an invalid QR is scanned. Just clear and reset the state (
Controller.resume_main_flow = None), show ErrorView, and return to the MainMenuView.This PR adds the above change and a matching new test for that flow.