DOC: Update several links #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcomer
reviewed
Mar 15, 2024
CHANGES
Outdated
| @@ -1 +1 @@ | |||
| Please see docs/source/whats_new.rst for a changelog. | |||
| Please see docs/source/whatsnew/index.rst for a changelog. | |||
There was a problem hiding this comment.
The index file doesn’t really tell you anything, so maybe point to the directory so a specific version can be selected? Alternatively have a link to the built docs?
Suggested change
| Please see docs/source/whatsnew/index.rst for a changelog. | |
| Please see docs/source/whatsnew/ for a changelog. |
There was a problem hiding this comment.
I think pointing to the directory makes sense, so have updated that plus addressed three more broken links and a redirect.
rcomer
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Updates several dated links in the documentation, and fixes two dead links to the feature creation example.
Other notes
On the install page (https://scitools.org.uk/cartopy/docs/latest/installing.html), I also suspect reference to OSGeo Live is outdated (at least, last mention on https://github.com/OSGeo/OSGeoLive/blob/master/CHANGES.txt is for version 0.17), but have not confirmed so left that alone.