Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V7 preview #481

Merged
merged 159 commits into from
Mar 14, 2021
Merged

V7 preview #481

merged 159 commits into from
Mar 14, 2021

Conversation

jfhenon
Copy link
Collaborator

@jfhenon jfhenon commented Mar 8, 2021

PR description

Checklist

Note that we require UI tests to ensure that the added feature will not be
nixed by some future fix and that there is at least some test-as-documentation
to indicate how the fix or enhancement is expected to behave.

  • - Added Cypress UI tests
  • - Ran npm test, ensuring linting passes and that Cypress UI tests keep
    coverage to at least the same percent (reflected in the coverage badge
    that should be updated after the tests run)
  • - Added any user documentation. Though not required, this can be a big
    help both for future users and for the PR reviewer.

jfhenon and others added 30 commits January 3, 2021 23:46
#36 look of opacity button should like the zoom button (without the d…
…y button is displaying the “color popup”.)
#38 The opacity button does not update with the current element
#37 Clicking anywhere on the bottom bar open color popup
#42 When you import an image,  dialog should disappear automatically
Fixes #53: 4th option for the background display fixed
#49 the x button does not work
@jfhenon jfhenon merged commit 7ff3c3a into SVG-Edit:V7-preview Mar 14, 2021
@lgtm-com
Copy link

lgtm-com bot commented Mar 14, 2021

This pull request introduces 6 alerts and fixes 1 when merging ad24d8f into c7d259f - view on LGTM.com

new alerts:

  • 4 for Unused variable, import, function or class
  • 1 for Useless assignment to local variable
  • 1 for Self assignment

fixed alerts:

  • 1 for Useless assignment to local variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants