bazel: refactor package level defaults to envoy_package(). (envoyprox…

…y#828) Introduced envoy_package() to set package-level defaults and reformatted all BUILD rules with this. Site specific imports can customize this in envoy_build_system.bzl.
RyanTheOptimist · Apr 24, 2017 · 9e3ab4e · 9e3ab4e
1 parent 84fa128
commit 9e3ab4e
Show file tree

Hide file tree

Showing 131 changed files with 791 additions and 250 deletions.
diff --git a/BUILD b/BUILD
@@ -1,4 +1,9 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_package",
+)
+
+envoy_package()
 
 genrule(
     name = "envoy_version",

diff --git a/bazel/envoy_build_system.bzl b/bazel/envoy_build_system.bzl
@@ -1,5 +1,8 @@
 load("@protobuf_bzl//:protobuf.bzl", "cc_proto_library")
 
+def envoy_package():
+    native.package(default_visibility = ["//visibility:public"])
+
 # Compute the final copts based on various options.
 def envoy_copts(repository):
     return [

diff --git a/ci/build_container/BUILD b/ci/build_container/BUILD
@@ -1,4 +1,9 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_package",
+)
+
+envoy_package()
 
 exports_files([
     "build_and_install_deps.sh",

diff --git a/ci/build_container/build_recipes/BUILD b/ci/build_container/build_recipes/BUILD
@@ -1,3 +1,8 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_package",
+)
+
+envoy_package()
 
 exports_files(glob(["*.sh"]))
diff --git a/configs/BUILD b/configs/BUILD
@@ -1,4 +1,9 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_package",
+)
+
+envoy_package()
 
 genrule(
     name = "example_configs",

diff --git a/examples/BUILD b/examples/BUILD
@@ -1,4 +1,9 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_package",
+)
+
+envoy_package()
 
 filegroup(
     name = "configs",

diff --git a/include/envoy/access_log/BUILD b/include/envoy/access_log/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "access_log_interface",

diff --git a/include/envoy/api/BUILD b/include/envoy/api/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "api_interface",

diff --git a/include/envoy/buffer/BUILD b/include/envoy/buffer/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "buffer_interface",

diff --git a/include/envoy/common/BUILD b/include/envoy/common/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 cc_library(
     name = "base_includes",

diff --git a/include/envoy/event/BUILD b/include/envoy/event/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "deferred_deletable",

diff --git a/include/envoy/filesystem/BUILD b/include/envoy/filesystem/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "filesystem_interface",

diff --git a/include/envoy/grpc/BUILD b/include/envoy/grpc/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "rpc_channel_interface",

diff --git a/include/envoy/http/BUILD b/include/envoy/http/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "access_log_interface",

diff --git a/include/envoy/init/BUILD b/include/envoy/init/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "init_interface",

diff --git a/include/envoy/json/BUILD b/include/envoy/json/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "json_object_interface",

diff --git a/include/envoy/local_info/BUILD b/include/envoy/local_info/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "local_info_interface",

diff --git a/include/envoy/mongo/BUILD b/include/envoy/mongo/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "bson_interface",

diff --git a/include/envoy/network/BUILD b/include/envoy/network/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "address_interface",

diff --git a/include/envoy/ratelimit/BUILD b/include/envoy/ratelimit/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "ratelimit_interface",

diff --git a/include/envoy/redis/BUILD b/include/envoy/redis/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "codec_interface",

diff --git a/include/envoy/router/BUILD b/include/envoy/router/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "rds_interface",

diff --git a/include/envoy/runtime/BUILD b/include/envoy/runtime/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "runtime_interface",

diff --git a/include/envoy/server/BUILD b/include/envoy/server/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "admin_interface",

diff --git a/include/envoy/ssl/BUILD b/include/envoy/ssl/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "connection_interface",

diff --git a/include/envoy/stats/BUILD b/include/envoy/stats/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "stats_interface",

diff --git a/include/envoy/thread/BUILD b/include/envoy/thread/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "thread_interface",

diff --git a/include/envoy/thread_local/BUILD b/include/envoy/thread_local/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "thread_local_interface",

diff --git a/include/envoy/tracing/BUILD b/include/envoy/tracing/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "context_interface",

diff --git a/include/envoy/upstream/BUILD b/include/envoy/upstream/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "cluster_manager_interface",

diff --git a/source/common/access_log/BUILD b/source/common/access_log/BUILD
@@ -1,6 +1,10 @@
-package(default_visibility = ["//visibility:public"])
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_library",
+    "envoy_package",
+)
 
-load("//bazel:envoy_build_system.bzl", "envoy_cc_library")
+envoy_package()
 
 envoy_cc_library(
     name = "access_log_manager_lib",