zeroize: Fix docs #709
Merged
zeroize: Fix docs #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aewag
force-pushed
the
zeroize-fix-docs
branch
from
f82bd0b
to
957f559
Compare
|
Thanks! Curious why these weren't caught by doctests... |
|
Yeah, I also didn't see initially why this wasn't caught. Tests were executed so I assumed that's fine. Just double checked and found the issue: The naming of the feature is By only fixing the feature naming: Just created a 2nd PR that sits on top of the current master with these fixes applied. This ran successfully the tests on my machine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've experimented with zeroize v1.5.0-pre and just stumbled upon some minor doc typos.