Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundle): closure to not rewrite polyfills for minification #4487

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

imcotton
Copy link
Contributor

Description:
Sorry I've never been using umd bundle in a ES5 environment w/o external polyfill (i.e. core-js) already existed, am I right?

Related issue (if exists):
fixes: #4427

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7935

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.2%) to 96.969%

Files with Coverage Reduction New Missed Lines %
src/internal/observable/fromPromise.ts 1 87.5%
src/internal/observable/fromIterable.ts 2 95.24%
src/internal/observable/fromObservable.ts 2 83.33%
Totals Coverage Status
Change from base Build 7933: 0.2%
Covered Lines: 5791
Relevant Lines: 5972

💛 - Coveralls

@kwonoj
Copy link
Member

kwonoj commented Jan 23, 2019

will this removes global variable exports? flag description just says about how does closure handles polyfills.

@imcotton
Copy link
Contributor Author

I think it won't, as mentioned here, this flag currently does no rewritten as it should be.

Same changing goes in facebook/react#12618.

@benlesh benlesh merged commit a1fedb9 into ReactiveX:master Jan 29, 2019
@benlesh
Copy link
Member

benlesh commented Jan 29, 2019

Thank you @imcotton!

@lock lock bot locked as resolved and limited conversation to collaborators Mar 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rxjs(umd file) will pollute global/window variable
4 participants