Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable features to generate dependency list and fix RPM installation. #343

Merged
merged 3 commits into from
Jun 7, 2024

Conversation

dgaliffiAMD
Copy link
Collaborator

For DEBIAN, enable CPACK_DEBIAN_PACKAGE_SHLIBDEPS to generate a package
dependency list.

For RPM, enable CPACK_RPM_PACKAGE_AUTOREQPROV to automatically generate
lists of shared libraries that this package requires and provides.

Fix dnf install failing due to dependency resolution

Auto-generation did not add it to the "provides" list, despite it being
included in the package when OMNITRACE_BUILD_LIBUNWIND is enabled. So,
manually include these in the "CPACK_RPM_PACKAGE_PROVIDES" parameter.

For DEBIAN, enable CPACK_DEBIAN_PACKAGE_SHLIBDEPS to generate a package
dependency list.

For RPM, enable CPACK_RPM_PACKAGE_AUTOREQPROV to automatically generate
lists of shared libraries that this package requires and provides.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
[Why]
`dnf install` fails dependency resolution

[How]
Auto-generation did not add it to the "provides" list, despite it being
included in the package when OMNITRACE_BUILD_LIBUNWIND is enabled. So,
manually include these in the "CPACK_RPM_PACKAGE_PROVIDES" parameter.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
@dgaliffiAMD dgaliffiAMD added cmake Modifies the CMake build system cpack Modifies the CPack packaging system labels Jun 5, 2024
@dgaliffiAMD
Copy link
Collaborator Author

For reference, the follow is the error when trying to install the RPM.

$ sudo yum install -v ./omnitrace-1.11.2-rocky9.4~ROCm60101~PAPI~OMPT.el9.x86_64.rpm 
[sudo] password for gliff: 
Loaded plugins: builddep, changelog, config-manager, copr, debug, debuginfo-install, download, generate_completion_cache, groups-manager, kpatch, needs-restarting, notify-packagekit, playground, repoclosure, repodiff, repograph, repomanage, reposync, system-upgrade
YUM version: 4.14.0

--> Starting dependency resolution
--> Finished dependency resolution
Error: 
 Problem: conflicting requests
  - nothing provides libunwind-ptrace.so.0()(64bit) needed by omnitrace-1.11.2-rocky9.4~ROCm60101~PAPI~OMPT.el9.x86_64 from @commandline
  - nothing provides libunwind-setjmp.so.0()(64bit) needed by omnitrace-1.11.2-rocky9.4~ROCm60101~PAPI~OMPT.el9.x86_64 from @commandline
  - nothing provides libunwind-x86_64.so.99()(64bit) needed by omnitrace-1.11.2-rocky9.4~ROCm60101~PAPI~OMPT.el9.x86_64 from @commandline
  - nothing provides libunwind.so.99()(64bit) needed by omnitrace-1.11.2-rocky9.4~ROCm60101~PAPI~OMPT.el9.x86_64 from @commandline
(try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
@jrmadsen jrmadsen merged commit 129580b into ROCm:main Jun 7, 2024
47 checks passed
@dgaliffiAMD dgaliffiAMD deleted the amd/dgaliffi/cpack-dependencies branch June 7, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Modifies the CMake build system cpack Modifies the CPack packaging system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants