Update CPack packaging for ROCm release support #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Look for ROCM_LIBPATH_VERSION environment variable to patch the CPACK_PACKAGE_VERSION. Add some status logs to output packaging information. Signed-off-by: David Galiffi <David.Galiffi@amd.com>
jrmadsen
requested changes
May 1, 2024
jrmadsen
approved these changes
May 2, 2024
There was a problem hiding this comment.
We should probably enable CPACK_DEBIAN_PACKAGE_SHLIBDEPS and CPACK_RPM_PACKAGE_AUTOREQ to auto-generate the dependencies (+ the similar cpack variables for generating what the package provides) but that should be in another PR.
|
Thanks for the feedback. I can make these changes in a future update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look for ROCM_LIBPATH_VERSION environment variable to patch the CPACK_PACKAGE_VERSION.
Add some status logs to output packaging information.