-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support external (i.e. user-defined) trace annotations #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrmadsen
added
enhancement
New feature or request
perfetto
Issue affects/involves perfetto features/capabilities
libomnitrace
Involves omnitrace library
libomnitrace-dl
Involves omnitrace-dl library
libomnitrace-user
Involves omnitrace-user library
omnitrace-python
Involves the omnitrace python profiler executable
libpyomnitrace
Involves the omnitrace python bindings
testing
Extends/improves/modifies testing
examples
Adds new example or modifies existing example
cmake
Modifies the CMake build system
labels
Nov 3, 2022
@koomie Looking for feedback on how the user-defined annotations should be specified. Example at the bottom of the first comment. LMK if you have any questions. |
- tweaked the python examples to be more balanced - updated the user-api example to conform to user API changes - moved the get/set for State and ThreadState to state.{hpp,cpp} - introduced user-provided trace annotations - added perfetto python category - moved coverage impl files around - created enumerations for mapping category enums to category types - created enumerations for mapping annotation type enums to annotation values - moved tracing::add_perfetto_annotations to tracing/annotation.hpp - utility make_index_sequence_range - libomnitrace-dl: omnitrace_push_category_region - libomnitrace-dl: omnitrace_pop_category_region - libomnitrace-user: omnitrace_user_push_annotated_region - libomnitrace-user: omnitrace_user_pop_annotated_region - libpyomnitrace: support extra annotations via annotate_trace config value - filename - line - last attempted instr in bytecode (lasti) - argcount - num local variables - stacksize - omnitrace-python: -a / --annotate-traces option
- Install texinfo
jrmadsen
force-pushed
the
user-trace-annotations
branch
from
November 11, 2022 08:35
c3aac3e
to
abc7fd3
Compare
jrmadsen
added a commit
to jrmadsen/omnitrace
that referenced
this pull request
Feb 2, 2023
* Support external (i.e. user-defined) trace annotations - tweaked the python examples to be more balanced - updated the user-api example to conform to user API changes - moved the get/set for State and ThreadState to state.{hpp,cpp} - introduced user-provided trace annotations - added perfetto python category - moved coverage impl files around - created enumerations for mapping category enums to category types - created enumerations for mapping annotation type enums to annotation values - moved tracing::add_perfetto_annotations to tracing/annotation.hpp - utility make_index_sequence_range - libomnitrace-dl: omnitrace_push_category_region - libomnitrace-dl: omnitrace_pop_category_region - libomnitrace-user: omnitrace_user_push_annotated_region - libomnitrace-user: omnitrace_user_pop_annotated_region - libpyomnitrace: support extra annotations via annotate_trace config value - filename - line - last attempted instr in bytecode (lasti) - argcount - num local variables - stacksize - omnitrace-python: -a / --annotate-traces option * tweak ubuntu-focal workflow * Fix installation of omnitrace-user headers * ubuntu-focal-codecov workflow update - Install texinfo * Update timemory submodule
jrmadsen
added a commit
to jrmadsen/omnitrace
that referenced
this pull request
Feb 2, 2023
* Support external (i.e. user-defined) trace annotations - tweaked the python examples to be more balanced - updated the user-api example to conform to user API changes - moved the get/set for State and ThreadState to state.{hpp,cpp} - introduced user-provided trace annotations - added perfetto python category - moved coverage impl files around - created enumerations for mapping category enums to category types - created enumerations for mapping annotation type enums to annotation values - moved tracing::add_perfetto_annotations to tracing/annotation.hpp - utility make_index_sequence_range - libomnitrace-dl: omnitrace_push_category_region - libomnitrace-dl: omnitrace_pop_category_region - libomnitrace-user: omnitrace_user_push_annotated_region - libomnitrace-user: omnitrace_user_pop_annotated_region - libpyomnitrace: support extra annotations via annotate_trace config value - filename - line - last attempted instr in bytecode (lasti) - argcount - num local variables - stacksize - omnitrace-python: -a / --annotate-traces option * tweak ubuntu-focal workflow * Fix installation of omnitrace-user headers * ubuntu-focal-codecov workflow update - Install texinfo * Update timemory submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cmake
Modifies the CMake build system
enhancement
New feature or request
examples
Adds new example or modifies existing example
libomnitrace
Involves omnitrace library
libomnitrace-dl
Involves omnitrace-dl library
libomnitrace-user
Involves omnitrace-user library
libpyomnitrace
Involves the omnitrace python bindings
omnitrace-python
Involves the omnitrace python profiler executable
perfetto
Issue affects/involves perfetto features/capabilities
testing
Extends/improves/modifies testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perfetto Python Annotations
Updated User API