Exposed the timeout of SPARQLWrapper #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joernhees
added
enhancement
|
i like the idea of improving the configurability of the SPARQLUpdateStore connection, but probably not restricted to the timeout parameter only. also as you can see, your change breaks current tests if no timeout is set. |
What do you have in mind? |
|
👍 |
|
eh, well can't hurt to have this at least until the full config can be restored for each request... |
joernhees
added a commit
that referenced
this pull request
Nov 28, 2015
Exposed the timeout of SPARQLWrapper
This was referenced Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to set a timeout on the connection in SPARQLStore. I can cause
sendall()in the underlying socket object to timeout through SPARQLWrapper, but SPARQLUpdateStore resets the timeout to 0. This change keeps the timeout in-between updates.Background:
I have been doing some experiments with sending SPARQL updates of increasing size and hit a limit where the underlying socket in the SPARQLUpdateStore is blocking in
sendall(). I check withnetstatand see the state of the connection is "CLOSE_WAIT", so the remote endpoint closed the connection. It seems likesendall()should return here; not sure.