Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch commits for SPARQLUpdateStore #486

Merged
merged 5 commits into from
Aug 11, 2015

Conversation

jpmccu
Copy link
Contributor

@jpmccu jpmccu commented May 26, 2015

SPARQLUpdateStore writes an HTTP transaction for each and every triple addition or deletion. When adding significant amounts of data via this API, this results in a lot of network chatter and significant delays while the transactions are completed. This change batches edits up until the user calls commit() or until a read operation is performed. The result should always be the same behavior from any given client's perspective, since all edits are applied before a read occurs.

Jim McCusker added 2 commits May 25, 2015 23:25
…e addition or deletion. When adding significant amounts of data via this API, this results in a lot of network chatter and significant delays while the transactions are completed. This change batches edits up until the user calls commit() or until a read operation is performed. The result should always be the same behavior from any given client's perspective, since all edits are applied before a read occurs.
@joernhees joernhees added enhancement New feature or request SPARQL performance store Related to a store. labels May 26, 2015
@joernhees
Copy link
Member

seems legit to me, but as this changes the current behavior of auto-committing changes, i think we should either put this in rdflib 5.x.x (as it breaks backwards compatibility according to http://semver.org) or maybe you could add an autocommit flag to its init which changes the store's behavior. If that flag defaults to True the change would be backwards compatible and could go into 4.2.1

@jpmccu
Copy link
Contributor Author

jpmccu commented May 26, 2015

I'll add the flag then.
On Tue, May 26, 2015 at 8:36 AM Jörn Hees notifications@github.com wrote:

seems legit to me, but as this changes the current behavior of
auto-committing changes, i think we should either put this in rdflib 5.x.x
(as it breaks backwards compatibility according to http://semver.org) or
maybe you could add an autocommit flag to its init which changes the
store's behavior. If that flag defaults to True the change would be
backwards compatible and could go into 4.2.1


Reply to this email directly or view it on GitHub
#486 (comment).

@joernhees
Copy link
Member

👍

@joernhees joernhees added this to the rdflib 4.2.1 milestone May 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance SPARQL store Related to a store.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants