Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix/ignore flake8 errors in store related code #1971

Merged

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented May 22, 2022

Summary of changes

This patch adds ignores for flake8 errors in store related code, it also
removes one unused import in rdflib/plugins/stores/sparqlconnector.py.

Mainly doing this in preparation for adding typing to rdflib/store.py which will invalidate large parts of the flakeheaven baseline there.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

@aucampia aucampia changed the title Fix/ignore flake8 errors in store related code style: fix/ignore flake8 errors in store related code May 22, 2022
@aucampia aucampia force-pushed the iwana-20220522T2220-fix_flake8_stores branch from 9c71ad4 to a1b834a Compare May 22, 2022 20:48
@coveralls
Copy link

coveralls commented May 22, 2022

Coverage Status

Coverage remained the same at 88.514% when pulling ae5771d on aucampia:iwana-20220522T2220-fix_flake8_stores into 958b9a1 on RDFLib:master.

@aucampia aucampia marked this pull request as ready for review May 22, 2022 20:55
@aucampia aucampia requested a review from a team May 22, 2022 21:15
@aucampia aucampia added the review wanted This indicates that the PR is ready for review label May 22, 2022
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This patch adds ignores for flake8 errors in store related code, it also
removes one unused import in `rdflib/plugins/stores/sparqlconnector.py`.
@aucampia aucampia force-pushed the iwana-20220522T2220-fix_flake8_stores branch from a1b834a to ae5771d Compare May 25, 2022 18:22
@aucampia aucampia merged commit 4ded2eb into RDFLib:master May 26, 2022
@ghost ghost removed the review wanted This indicates that the PR is ready for review label Jun 4, 2022
@aucampia aucampia deleted the iwana-20220522T2220-fix_flake8_stores branch June 4, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants