Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: earlier assert rewrite for test utitlities #1897

Merged
merged 1 commit into from
May 11, 2022

Conversation

aucampia
Copy link
Member

@aucampia aucampia commented May 8, 2022

Summary of changes

This patch moves the assert rewrite for test utilities to happen before
other imports to ensure that assert rewrites at the right time.

Without this some assert output were not formatted nicely with a diff
and just had AssertionError as output.

Checklist

  • Checked that there aren't other open pull requests for
    the same change.
  • Checked that all tests and type checking passes.
  • Considered granting push permissions to the PR branch,
    so maintainers can fix minor issues and keep your PR up to date.

This patch moves the assert rewrite for test utilities to happen before
other imports to ensure that assert rewrites at the right time.

Without this some assert output were not formatted nicely with a diff
and just had AssertionError as output.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.238% when pulling 3f24fdf on aucampia:iwana-20220508T1517-early_rewrite into eba1373 on RDFLib:master.

@aucampia aucampia requested a review from a team May 8, 2022 14:21
@aucampia aucampia added testing review wanted This indicates that the PR is ready for review labels May 8, 2022
@aucampia aucampia merged commit d3689cf into RDFLib:master May 11, 2022
@ghost ghost removed the review wanted This indicates that the PR is ready for review label Jun 4, 2022
@aucampia aucampia deleted the iwana-20220508T1517-early_rewrite branch June 4, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants