-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add Taskfile with development tasks #1867
build: add Taskfile with development tasks #1867
Conversation
739d6fb
to
dc61fe5
Compare
fccf5af
to
c4c77a6
Compare
This patch adds a Taskfile with various tasks that is useful for RDFLib development. Details of the available tasks can be seen from `task help` output and some more information is included in the RDFLib developers guide. For more information about Taskfiles see https://taskfile.dev/#/usage. The GitHub action pipeline was also changed to now use tasks from the Taskfile which simplifies the pipeline quite a bit. This patch also adds development container which can be used to run various development task and which can also be used with development container enabled tools such as VSCode or GitHub codespaces. This is all being done in preperation for moving coveralls reporting to the GitHub actions workflow. Other changes: - Removed the `Makefile` and associated `test/Dockerfile` as it is now replaced by a `Taskfile.yml`.
c4c77a6
to
a63a85a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general it looks good to me, even though I could not test all parts to be functional.
Only the one secret variable stuck out to me. Other then that I'm fine with it.
22.04 is the latest LTS and it should support ARM64.
Planning to merge before 2022-05-01 if there is no further feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me
Summary of changes
This patch adds a Taskfile with various tasks that is useful for
RDFLib development. Details of the available tasks can be seen from
task help
output and some more information is included in the RDFLibdevelopers guide.
For more information about Taskfiles see https://taskfile.dev/#/usage.
The GitHub action pipeline was also changed to now use tasks from the
Taskfile which simplifies the pipeline quite a bit.
This patch also adds development container which can be used to run
various development task and which can also be used with development
container enabled tools such as VSCode or GitHub codespaces.
This is all being done in preperation for moving coveralls reporting to
the GitHub actions workflow.
Other changes:
Makefile
and associatedtest/Dockerfile
as it is now replaced by aTaskfile.yml
.Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.