Remove testing and debug code from rdflib #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aucampia
force-pushed
the
iwana-20220418T1523-remove_deadcode
branch
from
45c89b3
to
53bac26
Compare
|
Probably best to only merge this after #1846 - but it is not entirely related and can be merged independently also. |
aucampia
requested review from
nicholascar,
a user,
white-gecko and
ashleysommer
ghost
approved these changes
Apr 18, 2022
aucampia
force-pushed
the
iwana-20220418T1523-remove_deadcode
branch
from
53bac26
to
fa28388
Compare
nicholascar
approved these changes
Apr 19, 2022
This patch removes code from `rdflib/` that does not seem like it belongs in `rdflib/`, most of it is related to doctest, some of it belongs in `test/` and was moved to `test/test_misc/test_collection.py`, and yet more of it seems to just be there for debugging purposes, though it would possibly be better to put that in a separate place if it is needed again or to debug using tests if possible. Other changes: - Removed an invocation of `rdflib.util.test` from `test_util.py`. This seems like an attempt to invoke doctest however pytest takes care of that so this is not needed.
aucampia
force-pushed
the
iwana-20220418T1523-remove_deadcode
branch
from
fa28388
to
604abba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This patch removes code from
rdflib/that does not seem like it belongsin
rdflib/, most of it is related to doctest, some of it belongs intest/and was moved totest/test_misc/test_collection.py, and yetmore of it seems to just be there for debugging purposes, though it
would possibly be better to put that in a separate place if it is needed
again or to debug using tests if possible.
Other changes:
rdflib.util.testfromtest_util.py. Thisseems like an attempt to invoke doctest however pytest takes care of
that so this is not needed.
Checklist
the same change.
so maintainers can fix minor issues and keep your PR up to date.