New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow hext to participate in RDF format roundtripping #1656

Merged

nicholascar merged 11 commits into master from roundtrip_hext

Jan 15, 2022

Member

nicholascar commented Jan 9, 2022

Until now, HexTuples parsing & serializing could not participate in RDF format roundtripping due to numerous failures. well, I've solved them by:

doing better JSON serializing
allowing the test_roundtrip.py functions to conflate "" with ""^^xsd:string, for hext only
skipping only 2 tests
allowing HexT parsing to treat a value "" as value, not None


          allow hext to participate in RDF format roundtripping

2c5b509

nicholascar requested review from aucampia and edmondchuc

January 9, 2022 13:15

aucampia reviewed

View reviewed changes

rdflib/plugins/serializers/hext.py Show resolved Hide resolved

aucampia reviewed

View reviewed changes

rdflib/plugins/serializers/hext.py Show resolved Hide resolved

aucampia reviewed

View reviewed changes

rdflib/plugins/parsers/hext.py Outdated Show resolved Hide resolved

aucampia reviewed

View reviewed changes

rdflib/plugins/parsers/hext.py Outdated Show resolved Hide resolved

aucampia reviewed

View reviewed changes

rdflib/plugins/parsers/hext.py Outdated Show resolved Hide resolved

aucampia reviewed

View reviewed changes

rdflib/plugins/parsers/hext.py Outdated Show resolved Hide resolved

aucampia reviewed

View reviewed changes

rdflib/plugins/parsers/hext.py Outdated Show resolved Hide resolved

aucampia approved these changes

View reviewed changes

Member

aucampia left a comment

Looks great, some suggestions but the only critical one is to manually specify the type of HextuplesSerializer.graph_type in rdflib/plugins/serializers/hext.py

aucampia reviewed

View reviewed changes

rdflib/plugins/serializers/hext.py Outdated Show resolved Hide resolved

Member

aucampia commented Jan 9, 2022

Making a PR with all changes included


          One typing fix and removal of redundant casts

f5736e5

Member

aucampia commented Jan 9, 2022 •

edited

Loading

One typing fix and removal of redundant casts #1657

nicholascar and others added 7 commits

January 10, 2022 00:55


          Update rdflib/plugins/serializers/hext.py

bf3b77a

Co-authored-by: Iwan Aucamp <aucampia@gmail.com>


          Update rdflib/plugins/parsers/hext.py

c332583

Co-authored-by: Iwan Aucamp <aucampia@gmail.com>


          Update rdflib/plugins/parsers/hext.py

da9c5a2

Co-authored-by: Iwan Aucamp <aucampia@gmail.com>


          Update rdflib/plugins/parsers/hext.py

09f1b0b

Co-authored-by: Iwan Aucamp <aucampia@gmail.com>


          Update rdflib/plugins/parsers/hext.py

73cfe6e

Co-authored-by: Iwan Aucamp <aucampia@gmail.com>


          Update rdflib/plugins/serializers/hext.py

6d3dd81

Co-authored-by: Iwan Aucamp <aucampia@gmail.com>


          Update rdflib/plugins/parsers/hext.py

0ff59c4

Co-authored-by: Iwan Aucamp <aucampia@gmail.com>

Member Author

nicholascar commented Jan 9, 2022

Thanks @aucampia. I added those casts to try and avoid some warnings shown in PyCharm but yeah, the code passed all MyPy tests without the casts. But then I did miss that type setting on graph_type as you saw! I used to be a C# developer once and all this Python typing takes me back to 2005...


          Merge pull request #1657 from aucampia/iwana-20220109T1436-roundtrip_…

e761074

…hext_fixes

One typing fix and removal of redundant casts

aucampia mentioned this pull request

Add xfail tests for a couple of issues #1658

Closed

Member Author

nicholascar commented Jan 10, 2022

I'll give this a few days but if there's no further review, I'll merge: it's a pretty small PR and has had one review!

nicholascar requested review from ashleysommer, a user and white-gecko

January 10, 2022 03:08

aucampia mentioned this pull request

Fixed the handling of escape sequences in the ntriples and nquads parsers #1663

Merged

Member

aucampia commented Jan 14, 2022

Think you should go ahead with the merge as this fixes some important things in serialization.

aucampia reviewed

View reviewed changes

rdflib/plugins/parsers/hext.py Outdated Show resolved Hide resolved


          Update rdflib/plugins/parsers/hext.py

0c92b22

Co-authored-by: Iwan Aucamp <aucampia@gmail.com>

nicholascar merged commit e8db150 into master

nicholascar deleted the roundtrip_hext branch

January 15, 2022 02:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet