Skip to content

Commit

Permalink
Merge pull request #807 from mdyd-dev/release-notes-02-dec-2019
Browse files Browse the repository at this point in the history
release notes
  • Loading branch information
Nagygyorgy committed Dec 2, 2019
2 parents 66510aa + 82a3008 commit 35428bf
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 0 deletions.
33 changes: 33 additions & 0 deletions app/views/pages/release-notes/02-DECEMBER-2019.liquid
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
---
converter: markdown
metadata:
title: Page identified based o physical_file_path, optional slug, improvement for profiling slow pages, fixing *_delete_all mutations
description: December 02, 2019
contributors: false
slug: release-notes/02-DECEMBER-2019
searchable: true
---

#### {{ page.metadata.description }}

<h4 class="release-note release-note__new">NEW</h4>

* update Page based on `physcal_file_path` instead of slug. This fixes UX issue - when pos-cli sync was enabled, modifying slug/format/method could create duplicate Page objects with the same physical file path. Fixes also UX issue which allowed you to have multiple Pages with the same slug - now uniqueness validation error will be triggered. Last but not least - **slug became optional** - by default path to page will correspond to file path. For example `/hello/world` will display content of `app/views/pages/hello/world`, previously you had to define slug as follows:
```
---
slug: /hello/world
---
Hello World
```

<h4 class="release-note release-note__improved">IMPROVED</h4>

* Profiler percentage output for [Profiling Slow Pages](/best-practices/performance/profiling-slow-pages)

<h4 class="release-note release-note__fixed">FIXED</h4>

Avoid race condition in *_delete_all mutations - since actual deletion takes place in a background, make sure that users created between scheduling a background task and executing it won't be deleted

## pos-cli changes

`pos-cli` changelog is [kept separately](https://github.com/mdyd-dev/pos-cli/blob/master/CHANGELOG.md).
5 changes: 5 additions & 0 deletions app/views/pages/release-notes/release-notes.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ searchable: false
</div>
<div class="col">
<ul class="list-unstyled">
<li>
<a href="/release-notes/25-NOVEMBER-2019">Page identified based o physical_file_path, optional slug, improvement for profiling slow pages, fixing *_delete_all mutations</a>
<br/>
<span>Dec 02</span>
</li>
<li>
<a href="/release-notes/25-NOVEMBER-2019">Service workers route, multiple queries via GraphiQL editor, improvements, fixes</a>
<br/>
Expand Down

0 comments on commit 35428bf

Please sign in to comment.