Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a _spendAllowance function to ERC20 & ERC777 #3170

Merged
merged 7 commits into from
Feb 9, 2022
Merged

Add a _spendAllowance function to ERC20 & ERC777 #3170

merged 7 commits into from
Feb 9, 2022

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Feb 7, 2022 •
edited
Loading

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Amxx Amxx changed the title Feature/erc20/unlimited approval Do not reduce approval on burnFrom if current allowance is type(uint256).max Feb 7, 2022
@Amxx Amxx mentioned this pull request Feb 7, 2022
Closed
@Amxx Amxx force-pushed the feature/ERC20/unlimitedApproval branch from 5527d66 to 3df8fc3 Compare February 7, 2022 15:23
@frangio
Copy link
Contributor

frangio commented Feb 8, 2022

Are we adding an internal _spendAllowance for use in both transferFrom and burnFrom?

@Amxx Amxx changed the title Do not reduce approval on burnFrom if current allowance is type(uint256).max Add a _spendAllowance function to ERC20 & ERC777 Feb 8, 2022
@frangio
Copy link
Contributor

frangio commented Feb 8, 2022

Sorry but the ERC777 naming changes are too much to include in an unrelated PR... Can you please split that out?

@Amxx Amxx force-pushed the feature/ERC20/unlimitedApproval branch from 68ad3c3 to c416a78 Compare February 9, 2022 08:18
@Amxx
Copy link
Collaborator Author

Amxx commented Feb 9, 2022

Sorry but the ERC777 naming changes are too much to include in an unrelated PR... Can you please split that out?

done

frangio
frangio approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@frangio frangio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@frangio frangio merged commit c5a6cae into OpenZeppelin:master Feb 9, 2022
frangio pushed a commit that referenced this pull request Feb 9, 2022
@Amxx @frangio
Add a _spendAllowance function to ERC20 & ERC777 (#3170)
494b1b9 
(cherry picked from commit c5a6cae)
@Amxx Amxx deleted the feature/ERC20/unlimitedApproval branch February 9, 2022 17:23
@NeoXtreem NeoXtreem mentioned this pull request Feb 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frangio frangio frangio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amxx @frangio