Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added OpenSPP category to spp_cutom_filter and spp_custom_filter_ui #587

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

reichie020212
Copy link
Member

Why is this change needed?

both OpenSPP Custom Filter and OpenSPP Custom Filter UI is not included in the OpenSPP category filter.

How was the change implemented?

Added OpenSPP in the manifest.py file of both spp_custom_filter and spp_custom_filter_ui modules

New unit tests

None

Unit tests executed by the author

None

How to test manually

  • Go to Apps Menu
  • Click the Update Apps List button in the top part of the page and click Update button on the modal
  • Reload the page.
  • Remove the Apps filter in the search bar.
  • in the Categories section, click the OpenSPP category.
  • Check if all OpenSPP modules are included.

Related links

#513

@reichie020212 reichie020212 linked an issue Sep 13, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Sep 13, 2024

@kneckinator kneckinator merged commit 50f8daf into 17.0 Sep 17, 2024
8 of 10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
@kneckinator kneckinator deleted the add-category-for-openspp branch September 17, 2024 06:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apps - "Category" filter
4 participants