Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where long ssid's were not being saved in keychain #211

Merged

Conversation

ErrorErrorError
Copy link
Collaborator

This fixes issue #189.

It also fixes rare issue when random characters would appear if ssid.count == 32.

…xed rare occasions when Network names were showing random characters.

	- This was due to no null termination in `char[32]` was not found since the array was full.
@ErrorErrorError ErrorErrorError added the enhancement New feature or request label Nov 21, 2020
@williambj1
Copy link
Collaborator

Will merge once @masnormen confirms it works.

@williambj1 williambj1 added this to the v1.0.2 milestone Nov 22, 2020
@masnormen
Copy link
Contributor

masnormen commented Nov 23, 2020

Hello, I tried to run the built binary in #189
I deleted the previous .app and then extracted the newly built app. But when I open it shows "HeliPort Running At An Unexpected Path", which is strange because I already placed it from the Applications folder.

Any idea why this happen?

Edit: Note that I didn't launch it from login. In fact I disabled launch at login first from the prev version. I run the built HeliPort manually from Applications folder but it still show the message

@masnormen
Copy link
Contributor

Update: turns out the problem is the archive manager. Now it runs.

It's working*. It now adds the password to keychain.

image

*) However, there is another problem. I can only join the network using the "Join Other Network" menu. It keeps scanning and not finding my network. I waited for like half an hour but it still keeps scanning for my network. But, it can find my network easily if I renamed it to a shorter name.

Should I open a new issue, or is this related to this PR?

@ErrorErrorError
Copy link
Collaborator Author

Update: turns out the problem is the archive manager. Now it runs.

It's working*. It now adds the password to keychain.

image

*) However, there is another problem. I can only join the network using the "Join Other Network" menu. It keeps scanning and not finding my network. I waited for like half an hour but it still keeps scanning for my network. But, it can find my network easily if I renamed it to a shorter name.

Should I open a new issue, or is this related to this PR?

Hm, I always had that issue with long SSID name but it would eventually show up. I will check it out and see what's going on.

@williambj1 williambj1 merged commit 6201c00 into OpenIntelWireless:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

4 participants