Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: search dapps by urls #2133

Merged
merged 2 commits into from
Dec 5, 2022
Merged

feat: search dapps by urls #2133

merged 2 commits into from
Dec 5, 2022

Conversation

kwoktung
Copy link
Contributor

@kwoktung kwoktung commented Dec 5, 2022

No description provided.

@kwoktung kwoktung requested a review from a team as a code owner December 5, 2022 02:22
@what-the-diff
Copy link

what-the-diff bot commented Dec 5, 2022

  • Add searchDappsWithUrl and searchDappsWithRegExp to ServiceDiscover
  • Change the order of dappFavorites in discoverSlice reducer
  • Use new methods from serviceDiscover for favorites list on Discover page

@kwoktung kwoktung enabled auto-merge (squash) December 5, 2022 02:38
@github-actions
Copy link

github-actions bot commented Dec 5, 2022 •
edited
Loading

Bundle Stats-web bundle diff

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Type Total bundle size % Changed
80 bundled 25.13 MB -> 25.13 MB (+1.04 KB) +0.00%
View detailed bundle breakdown

Added

Asset Type File Size % Changed
static/js/app.51b82b89.chunk.js bundled 0 B -> 11.05 MB (+11.05 MB) -

Removed

Asset Type File Size % Changed
static/js/app.364d7790.chunk.js bundled 11.05 MB -> 0 B (-11.05 MB) -100%

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Type File Size % Changed
asset-manifest.json bundled 6.16 KB 0%
favicon-16.png bundled 580 B 0%
favicon-32.png bundled 1.14 KB 0%
favicon.ico bundled 14.17 KB 0%
index.html bundled 4 KB 0%
serve.json bundled 207 B 0%
static/js/0.2f7427da.chunk.js bundled 8.26 KB 0%
static/js/3.aafede8d.chunk.js bundled 12.2 MB 0%
static/js/3.aafede8d.chunk.js.LICENSE.txt bundled 16.9 KB 0%
static/js/runtime~app.507dad16.js bundled 2.22 KB 0%
static/media/3d_cloud_lock.b511e659.png bundled 6.22 KB 0%
static/media/3d_recovery_phrase.dcdbd631.png bundled 29.33 KB 0%
static/media/MoonPay.6aa29168.png bundled 3.14 KB 0%
static/media/NFT_placeholder_bg.dd61ac53.png bundled 189.33 KB 0%
static/media/NoRisks.51a2d40f.png bundled 77.1 KB 0%
static/media/PlusJakartaSans-Bold.669b6c57.ttf bundled 122.8 KB 0%
static/media/PlusJakartaSans-Medium.82a1829c.ttf bundled 123.18 KB 0%
static/media/PlusJakartaSans-SemiBold.d2391ea6.ttf bundled 123.23 KB 0%
static/media/RobotoMono-Regular.34e46962.ttf bundled 84.87 KB 0%
static/media/bitcoin_cash.830e1ff6.png bundled 1.24 KB 0%
static/media/bitcoin_gold.ef1fef2d.png bundled 1.11 KB 0%
static/media/bitcoin_shade.7344188d.png bundled 1.36 KB 0%
static/media/blur-qrcode.98bf42ab.png bundled 43.14 KB 0%
static/media/circleweb.946db04c.png bundled 1.07 KB 0%
static/media/coffee.1f09e13e.png bundled 1.01 KB 0%
static/media/collection_default_logo.56a1c615.png bundled 17.97 KB 0%
static/media/dappIcon_multichain.54d7ea07.png bundled 1.11 KB 0%
static/media/dapp_colour.5dd0344d.png bundled 4.67 KB 0%
static/media/desk_reveal.20570ffc.png bundled 10 KB 0%
static/media/desk_security.6671c2f4.png bundled 10.21 KB 0%
static/media/desk_settings.19ce0c79.png bundled 16.24 KB 0%
static/media/desk_topbar.141ef7ad.png bundled 26.65 KB 0%
static/media/deviceIcon_mini.96e3b384.png bundled 1.92 KB 0%
static/media/device_classic_touch.d5143074.png bundled 49.31 KB 0%
static/media/device_mini_classic_touch.8e45f230.png bundled 61.7 KB 0%
static/media/digibyte.4e16467a.png bundled 5.74 KB 0%
static/media/doge.890ef49d.png bundled 1.55 KB 0%
static/media/einstein.3b0d9a8b.png bundled 1.71 KB 0%
static/media/eth_logo.be8911f3.png bundled 7.08 KB 0%
static/media/eth_staking.6d8f2526.png bundled 27.55 KB 0%
static/media/flower.2e9f4aa5.png bundled 2.01 KB 0%
static/media/ic_pair_hint_scan_lite.ee34873f.png bundled 61.58 KB 0%
static/media/jupiter.bd25d48f.png bundled 1.84 KB 0%
static/media/keep_device_close.07d8f868.png bundled 168.22 KB 0%
static/media/kele_pool.8ff3dce4.png bundled 7.16 KB 0%
static/media/litecoin.ea75b8bb.png bundled 1 KB 0%
static/media/logo.b0cff82f.png bundled 1.25 KB 0%
static/media/logo_imtoken.3d2301dd.png bundled 2.22 KB 0%
static/media/logo_metamask.dd1c33eb.png bundled 1.57 KB 0%
static/media/logo_round.5d03617b.png bundled 9.66 KB 0%
static/media/mobile_reveal.f0a02ba0.png bundled 12.15 KB 0%
static/media/mobile_security.f850c96e.png bundled 29.08 KB 0%
static/media/mobile_settings.45b93463.png bundled 16.61 KB 0%
static/media/mobile_topbar.2ea77d7b.png bundled 16.13 KB 0%
static/media/multibit.fcf4e203.png bundled 1.33 KB 0%
static/media/myetherwallet.6f4a9180.png bundled 1.45 KB 0%
static/media/namecoin.ede6f2a7.png bundled 1004 B 0%
static/media/onekey-lite.583b6533.png bundled 56.28 KB 0%
static/media/red_x.c8d26966.png bundled 1.23 KB 0%
static/media/restore-classic-device.402d51b9.png bundled 5.97 KB 0%
static/media/restore-mini-device.670169a1.png bundled 3.96 KB 0%
static/media/restore-touch-device.c7ac892d.png bundled 6.58 KB 0%
static/media/rooster.bc5b8889.png bundled 1.32 KB 0%
static/media/saturn.262e7bc7.png bundled 1.75 KB 0%
static/media/setup-new-classic-device.8b586d89.png bundled 5.9 KB 0%
static/media/setup-new-mini-device.a7fade53.png bundled 4.01 KB 0%
static/media/setup-new-touch-device.b46e3b51.png bundled 6.59 KB 0%
static/media/splash.0c4c32ed.png bundled 7.19 KB 0%
static/media/splash.61ad4e4f.svg bundled 1.02 KB 0%
static/media/starweb.98c57bc9.png bundled 1.18 KB 0%
static/media/swft_logo.ca134069.png bundled 1.2 KB 0%
static/media/unboxing.3bef9b5f.png bundled 45.57 KB 0%
static/media/xrc.acd86b7e.png bundled 1.12 KB 0%
static/media/zbar.wasm.235eff51.bin bundled 227.34 KB 0%
static/media/zcash.772fbabc.png bundled 1.27 KB 0%
static/media/zoom-wallpaper-1.dd23dada.jpg bundled 20.22 KB 0%
static/media/zoom-wallpaper-2.92d92e4d.jpg bundled 29.2 KB 0%
static/media/zoom-wallpaper-3.8cf26b09.jpg bundled 59.17 KB 0%
static/media/zoom-wallpaper-4.3157ccb0.jpg bundled 1.58 KB 0%

@github-actions
Copy link

github-actions bot commented Dec 5, 2022 •
edited
Loading

👋 Successfully deployed the latest commit 5027272119ae6e6940d4a3890cd96ad3b096b6e1 to https://app.onekeytest.com at 5/12/2022, 11:32:55

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

Bundle Stats-ios bundle diff

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Type Total bundle size % Changed
1 bundled 30.81 MB -> 30.81 MB (+1.42 KB) +0.00%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset Type File Size % Changed
bundle bundled 30.81 MB -> 30.81 MB (+1.42 KB) +0.00%

Smaller

No assets were smaller

Unchanged

No assets were unchanged

@kwoktung kwoktung merged commit 7dbc5fc into onekey Dec 5, 2022
@kwoktung kwoktung deleted the fix_discover_api branch December 5, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loatheb loatheb loatheb left review comments

@sunnylqm sunnylqm sunnylqm approved these changes

@qwang1113 qwang1113 qwang1113 approved these changes

@ByteZhang1024 ByteZhang1024 ByteZhang1024 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kwoktung @sunnylqm @qwang1113 @loatheb @ByteZhang1024