Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prettier to newest version #1312

Merged
merged 6 commits into from
Aug 19, 2022
Merged

Update prettier to newest version #1312

merged 6 commits into from
Aug 19, 2022

Conversation

MarcinJuraszek
Copy link
Contributor

Description

Update prettier to newest version

Main changes in the PR:

  1. Update prettier to newest version and auto-format the code with it

Validation

Validation performed:

  1. it builds!

Unit Tests added:

No

End-to-end tests added:

No

Additional Requirements

Change file added:

Yes

@azure-pipelines
Copy link

Failed to compute bundle size changes with error:

Baseline CI build failed, cannot generate bundle analysis at this time


Baseline commit: b290bd7

@MarcinJuraszek MarcinJuraszek marked this pull request as ready for review August 18, 2022 16:37
@MarcinJuraszek MarcinJuraszek requested a review from a team as a code owner August 18, 2022 16:37
@azure-pipelines
Copy link

Analyzed commit id : 5adf124


@microsoft/bundle-analysis-app: -7 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
main.js82.59 KB82.58 KB -7 Bytes
Total Size82.59 KB82.58 KB -7 Bytes

Baseline commit: a2ab648

@erinha
Copy link
Contributor

erinha commented Aug 18, 2022

I noticed that no test files have been updated (under packages/teams-js/test). When I open the repo in VS Code in your branch and open a test file, I see that VS Code has red squiggles highlighting additional changes that are required in the test files. Is it possible for you to update the test files too?

@azure-pipelines
Copy link

Analyzed commit id : cd87b77


@microsoft/bundle-analysis-app: -7 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
main.js82.59 KB82.58 KB -7 Bytes
Total Size82.59 KB82.58 KB -7 Bytes

Baseline commit: a2ab648

Copy link
Contributor

@erinha erinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this, thank you!

@azure-pipelines
Copy link

Analyzed commit id : 060fefb


@microsoft/bundle-analysis-app: -7 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
main.js82.59 KB82.58 KB -7 Bytes
Total Size82.59 KB82.58 KB -7 Bytes

Baseline commit: a2ab648

Copy link
Contributor

@AE-MS AE-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MarcinJuraszek MarcinJuraszek enabled auto-merge (squash) August 18, 2022 22:11
@azure-pipelines
Copy link

Analyzed commit id : 8884314


@microsoft/bundle-analysis-app: -7 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
main.js82.59 KB82.58 KB -7 Bytes
Total Size82.59 KB82.58 KB -7 Bytes

Baseline commit: b290bd7

@MarcinJuraszek MarcinJuraszek merged commit 5bbc69c into main Aug 19, 2022
@MarcinJuraszek MarcinJuraszek deleted the marcinj/prettier branch August 19, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants