host_exerciser: correct handling of local memory width #3126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 9199368433Details
💛 - Coveralls |
pcolberg
reviewed
May 22, 2024
Reference FIMs pass only a single bank of local memory to HE MEM. Instead of building a size matcher for what is supposed to be a simple test, HE MEM accepts the loss of wide host data flowing through narrow local memory. HE MEM version 4 exposes the local memory width in a CSR. Signed-off-by: Michael Adler <michael.adler@intel.com>
michael-adler
force-pushed
the
mcadler/he_mem
branch
from
651f82f
to
a1e3d1b
Compare
pcolberg
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference FIMs pass only a single bank of local memory to HE MEM. Instead of building a size matcher for what is supposed to be a simple test, HE MEM accepts the loss of wide host data flowing through narrow local memory.
HE MEM version 4 exposes the local memory width in a CSR.
Tests run:
New HW on n6001, iseries-dk_x16