Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove clx he loopback sub command #3059

Merged
merged 3 commits into from
Dec 15, 2023
Merged

fix: remove clx he loopback sub command #3059

merged 3 commits into from
Dec 15, 2023

Conversation

anandaravuri
Copy link
Contributor

@anandaravuri anandaravuri commented Dec 13, 2023 •
edited
Loading

CXL host exerciser doesn’t support loopback feature, so remove lpbk sub command

@anandaravuri anandaravuri requested a review from a team as a code owner December 13, 2023 23:54
@coveralls
Copy link

coveralls commented Dec 14, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7227872530

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 66.568%
Totals Coverage Status
Change from base Build 7215478348: 0.08%
Covered Lines: 15756
Relevant Lines: 23669
💛 - Coveralls

fpgamatt
fpgamatt reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@fpgamatt fpgamatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit message as to why loopback sub command is being removed.

@anandaravuri
Copy link
Contributor Author

Please update the commit message as to why loopback sub command is being removed.

Ananda: updated commit meassge with comments

@fpgamatt
Copy link
Contributor

I don't see "CXL host exerciser doesn’t support loopback feature, so remove lpbk sub command" in the commit message. I even pulled your branch locally and checked.

anandaravuri and others added 2 commits December 15, 2023 14:11
@anandaravuri
fix: remove clx he loopback sub command
63eaad3 
 CXL host exerciser doesn’t support loopback feature, so remove lpbk sub command

Signed-off-by: anandaravuri <ananda.ravuri@intel.com>
@tswhison @anandaravuri
Fix: define PCI_STD_NUM_BARS when not found (#3061)
b1d1182 
### Description
A recent checkin began relying on sys/pci.h for its definition of PCI_STD_NUM_BARS.
It seems that some distributions don't have a version of that file that defines PCI_STD_NUM_BARS.
This change defines it to 6 when not found.

### Collateral (docs, reports, design examples, case IDs):



- [ ] Document Update Required? (Specify FIM/AFU/Scripts)

### Tests added:


### Tests run:
CI

Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
@anandaravuri anandaravuri requested a review from a team as a code owner December 15, 2023 22:18
tswhison
tswhison approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@tswhison tswhison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updated message.

@anandaravuri anandaravuri merged commit 1d67280 into master Dec 15, 2023
27 checks passed
@anandaravuri anandaravuri deleted the aravuri/remove_clx_lpbk branch December 15, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpgamatt fpgamatt fpgamatt left review comments

@tswhison tswhison tswhison approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anandaravuri @coveralls @fpgamatt @tswhison