Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: use argparse subparsers in opae.io #3023

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Conversation

tswhison
Copy link
Contributor

@tswhison tswhison commented Oct 10, 2023

Description

Use argparse subparsers instead of parse_known_args(), so
that the help information for sub-options can be auto-generated.

Bump revision to 1.0.0 - in order to run a script, the new 'script'
sub-option is required:
Before the change: opae.io do_something.py a b c
As of the change: opae.io script do_something.py a b c
The change is required due to the nature of argparse subparsers.

Collateral (docs, reports, design examples, case IDs):

  • Document Update Required? (Specify FIM/AFU/Scripts)
    fpga_tools/opae.io/opae.io.md

Tests added:

Tests run:

Manual verification of all opae.io commands.

Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
@tswhison tswhison self-assigned this Oct 10, 2023
@tswhison tswhison requested a review from a team as a code owner October 10, 2023 23:54
fpgamatt
fpgamatt previously approved these changes Oct 11, 2023
anandaravuri
anandaravuri previously approved these changes Oct 11, 2023
Signed-off-by: Tim Whisonant <tim.whisonant@intel.com>
@tswhison tswhison dismissed stale reviews from anandaravuri and fpgamatt via a7dfbce October 11, 2023 18:33
@tswhison tswhison merged commit 38a8534 into master Oct 11, 2023
31 checks passed
@tswhison tswhison deleted the tswhison/opae.io_parse branch October 11, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants