host_exerciser computed sum of reads+writes incorrectly #2931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
host_exerciser assumed read and write traffic were identical when computing lpbk and trput bandwidth. Use the actual count of reads and writes instead of just doubling writes.
Pull Request Test Coverage Report for Build 4798843215
💛 - Coveralls |
pcolberg
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Thanks @michael-adler! This should be backported to OFS 2023.1, correct?
Yes, I think that would be a good idea. Leaving that to you for proper tagging. |
pcolberg
pushed a commit
to pcolberg/opae-sdk
that referenced
this pull request
Apr 25, 2023
host_exerciser assumed read and write traffic were identical when computing lpbk and trput bandwidth. Use the actual count of reads and writes instead of just doubling writes. (cherry picked from commit 980db37)
pcolberg
pushed a commit
that referenced
this pull request
Apr 25, 2023
host_exerciser assumed read and write traffic were identical when computing lpbk and trput bandwidth. Use the actual count of reads and writes instead of just doubling writes. (cherry picked from commit 980db37)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
host_exerciser assumed read and write traffic were identical when computing lpbk and trput bandwidth. Use the actual count of reads and writes instead of just doubling writes.