fpgainfo: for N501x add show board info read from BMC #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4164882080
💛 - Coveralls |
| @@ -189,7 +205,9 @@ fpga_result print_bom_info(const fpga_token token) | |||
| if (mac_addr.ether_addr_octet[3] == 0x2d) | |||
| serial_name[16] = '0'; //N5013 | |||
| uint32_t number = (mac_addr.ether_addr_octet[4] << 4) + (mac_addr.ether_addr_octet[5] >> 4); | |||
| printf("%-32s : %s.%04u\n", "Board Serial", serial_name, number); | |||
| char board_info[FPGA_VAR_BUF_LEN] = { 0 }; | |||
| read_n5014_board_info(token, board_info); | |||
There was a problem hiding this comment.
if (read_n5014_board_info(token, board_info) == FPFG_OK)
printf("%-32s : %s.%04u (%s)\n", "Board Serial", serial_name, number, board_info)
else
printf("%-32s : %s.%04u (%s)\n", "Board Serial", serial_name, number, "N/A")
There was a problem hiding this comment.
OK I will add check, just leaving out the last part in case of failure.
rchriste1
force-pushed
the
rchriste/n501x-fpgainfo-boardinfo
branch
from
e336385
to
9e85267
Compare
Signed-off-by: Roger Christensen <rc@silicom.dk>
rchriste1
force-pushed
the
rchriste/n501x-fpgainfo-boardinfo
branch
from
9e85267
to
41c8163
Compare
anandaravuri
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roger Christensen rc@silicom.dk