host_exerciser updates #2355
Merged
host_exerciser updates #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Read the AFU frequency from a new CSR. - Add tests for PCIe atomic functions, including validating that each function is performed properly. - Fill the source buffer with random data instead of the same pattern over and over so that read errors are more likely to be found. - Make the log level work. Dump a few lines of the buffers in some modes.
anandaravuri
previously approved these changes
Nov 2, 2021
tswhison
previously approved these changes
Nov 2, 2021
| @@ -331,6 +356,10 @@ class host_exerciser : public test_afu { | |||
| // Configures test rollover or test termination | |||
| app_.add_option("--continuousmode", he_continuousmode_, "test rollover or test termination")->default_val("false"); | |||
|
|
|||
| // Atomic function | |||
| app_.add_option("--atomic", he_req_atomic_func_, "atomic requests (only permitted in combination with lpbk/cl_1)") | |||
There was a problem hiding this comment.
Should he_req_atomic_func_ be initialized in the constructor?
| @@ -346,12 +375,14 @@ class host_exerciser : public test_afu { | |||
| app_.add_option("--contmodetime", he_contmodetime_, | |||
| "Continuous mode time in seconds")->default_val("0"); | |||
|
|
|||
| app_.add_option("--clock-mhz", he_clock_mhz_, | |||
There was a problem hiding this comment.
Should he_clock_mhz_ be initialized in the constructor?
There was a problem hiding this comment.
Isn't that what default_val is for? That's how all the other params are handled, too.
|
|
||
| // In atomic mode, at most the first 8 bytes of each line will be | ||
| // updated and copied. In the source buffer, write a function of | ||
| // the value at the start of each line to the second postion so |
There was a problem hiding this comment.
Fixed typo. Please approve again.
michael-adler
dismissed stale reviews from tswhison and anandaravuri
via
625d825
anandaravuri
approved these changes
Nov 2, 2021
anandaravuri
pushed a commit
that referenced
this pull request
Nov 3, 2021
host_exerciser updates - Read the AFU frequency from a new CSR. - Add tests for PCIe atomic functions, including validating that each function is performed properly. - Fill the source buffer with random data instead of the same pattern over and over so that read errors are more likely to be found. - Make the log level work. Dump a few lines of the buffers in some modes.
anandaravuri
added a commit
that referenced
this pull request
Nov 3, 2021
host_exerciser updates - Read the AFU frequency from a new CSR. - Add tests for PCIe atomic functions, including validating that each function is performed properly. - Fill the source buffer with random data instead of the same pattern over and over so that read errors are more likely to be found. - Make the log level work. Dump a few lines of the buffers in some modes. Co-authored-by: Michael Adler <Michael.Adler@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is performed properly.
and over so that read errors are more likely to be found.