pacsign deps #2018
Merged
pacsign deps #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pkcs11 package is only needed when using the pkcs11 hsm manager. Listing it as a required module makes the PACSign entry point hard fail when it is not available: pkg_resources.DistributionNotFound: The 'python-pkcs11' distribution was not found and is required by pacsign Make PACSign usable with the openssl hsm manager only, by listing the pkcs11 package as an extra requirement. Signed-off-by: Martin Hundebøll <mhu@silicom.dk>
The Cython package isn't used anywhere, so avoid breaking entry points when it is not available: pkg_resources.DistributionNotFound: The 'cython' distribution was not found and is required by pacsign Signed-off-by: Martin Hundebøll <mhu@silicom.dk>
tswhison
approved these changes
Apr 28, 2021
r-rojo
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.