Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opae.admin: added regmap_debugfs.py #1731

Merged
merged 6 commits into from
Oct 30, 2020
Merged

Conversation

fpgamatt
Copy link
Contributor

Add a tool to help access the debugfs interface to regmaps
created in the linux kernel.

Signed-off-by: Matthew Gerlach matthew.gerlach@linux.intel.com

@fpgamatt fpgamatt self-assigned this Oct 27, 2020
Copy link
Contributor

@tswhison tswhison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fpgamatt fpgamatt force-pushed the mgerlach/add-regmap-debugfs branch 2 times, most recently from b51c100 to 3b8e758 Compare October 28, 2020 16:05
Copy link
Contributor

@dasm dasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just couple more minor things.
I would suggest to at least reconsider raise vs sys.exit. However, if you're fine with that, we can merge it.

python/opae.admin/opae/admin/tools/regmap_debugfs.py Outdated Show resolved Hide resolved
python/opae.admin/opae/admin/tools/regmap_debugfs.py Outdated Show resolved Hide resolved
python/opae.admin/opae/admin/tools/regmap_debugfs.py Outdated Show resolved Hide resolved
python/opae.admin/setup.py Outdated Show resolved Hide resolved
@fpgamatt fpgamatt force-pushed the mgerlach/add-regmap-debugfs branch 2 times, most recently from 4f1d116 to 9ba5aa1 Compare October 28, 2020 18:58
Add a tool to help access the debugfs interface to regmaps
created in the linux kernel.

Signed-off-by: Matthew Gerlach <matthew.gerlach@linux.intel.com>
Copy link
Contributor

@dasm dasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fpgamatt for your work.

@fpgamatt fpgamatt merged commit cae59f6 into master Oct 30, 2020
@fpgamatt fpgamatt deleted the mgerlach/add-regmap-debugfs branch October 30, 2020 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants