Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in bel_power_regulator_info of N6000 Board #2996

Closed
umairsiddiqui-digitek opened this issue Aug 7, 2023 · 2 comments
Closed

error in bel_power_regulator_info of N6000 Board #2996

umairsiddiqui-digitek opened this issue Aug 7, 2023 · 2 comments
Assignees

Comments

@umairsiddiqui-digitek
Copy link

umairsiddiqui-digitek commented Aug 7, 2023

found error(s) in bel_power_regulator_info of N6000 Board:

https://github.com/OFS/opae-sdk/blob/4cb9d59102415b6393b784502c7fd1d37366066b/libraries/libboard/board_n6000/board_event_log.c#L163C1-L176C3

BEL_PWR_REG_IR38062_VIN & BEL_PWR_REG_IR38062_TEMP have incorrect labels and units
similarly

BEL_PWR_REG_IR38063_VIN & BEL_PWR_REG_IR38063_TEMP
and
BEL_PWR_REG_ISL68220_VIN & BEL_PWR_REG_ISL68220_TEMP
are also incorrect

Also the resoluation for temperature sensors should be 2.

it should be

static struct bel_sensor_info bel_power_regulator_info[] = {
	[BEL_PWR_REG_IR38062_VOUT]  = { .label = "IR38062 Voltage",      .unit = "mV", .resolution = 1 },
	[BEL_PWR_REG_IR38062_IOUT]  = { .label = "IR38062 Current",      .unit = "mA", .resolution = 1 },
	[BEL_PWR_REG_IR38062_VIN]   = { .label = "IR38062 Input",        .unit = "mV", .resolution = 1 },
	[BEL_PWR_REG_IR38062_TEMP]  = { .label = "IR38062 Temperature",  .unit = "°C", .resolution = 2 },
	[BEL_PWR_REG_IR38063_VOUT]  = { .label = "IR38063 Voltage",      .unit = "mV", .resolution = 1 },
	[BEL_PWR_REG_IR38063_IOUT]  = { .label = "IR38063 Current",      .unit = "mA", .resolution = 1 },
	[BEL_PWR_REG_IR38063_VIN]   = { .label = "IR38063 Input",        .unit = "mV", .resolution = 1 },
	[BEL_PWR_REG_IR38063_TEMP]  = { .label = "IR38063 Temperature",  .unit = "°C", .resolution = 2 },
	[BEL_PWR_REG_ISL68220_VOUT] = { .label = "ISL68220 Voltage",     .unit = "mV", .resolution = 1 },
	[BEL_PWR_REG_ISL68220_IOUT] = { .label = "ISL68220 Current",     .unit = "mA", .resolution = 1 },
	[BEL_PWR_REG_ISL68220_VIN]  = { .label = "ISL68220 Input",       .unit = "mV", .resolution = 1 },
	[BEL_PWR_REG_ISL68220_TEMP] = { .label = "ISL68220 Temperature", .unit = "°C", .resolution = 2 }
};

@aditikum
Copy link
Contributor

aditikum commented Aug 8, 2023

Hi @umairsiddiqui-digitek, thank you for notifying us of this issue. We'll review it and assign someone to address it

anandaravuri added a commit that referenced this issue Aug 8, 2023
error in bel_power_regulator_info of N6000 Board
#2996

Signed-off-by: anandaravuri <ananda.ravuri@intel.com>
@anandaravuri
Copy link
Contributor

Fixed in PR #2997

anandaravuri added a commit that referenced this issue Aug 10, 2023
error in bel_power_regulator_info of N6000 Board
#2996

Signed-off-by: anandaravuri <ananda.ravuri@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants