Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] web_notify: action button name and close #2932

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][IMP] web_notify: action button name and close #2932

wants to merge 1 commit into from
+57 −38

Conversation

chienandalu
Copy link
Member

FW of

Includes:

  • We can now set a button name to the notification action.
  • We can set an icon button as well.
  • After the button is clicked, the notification gets closed.

cc @Tecnativa

please review @sergio-teruel @CarlosRoca13

@chienandalu
[IMP] web_notify: action button name and close
1fe3edc 
- We can now set a button name to the notification action.
- We can set an icon button as well.
- After the button is clicked, the notification gets closed.
@pedrobaeza pedrobaeza added this to the 16.0 milestone Sep 21, 2024
@pedrobaeza
Copy link
Member

Let's try, but it seems there's a general problem with tours:

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-2932-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 21, 2024
@OCA-git-bot
Merge PR #2932 into 16.0
4512f8f 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-2932-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2932-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 23, 2024
@OCA-git-bot
Merge PR #2932 into 16.0
d56ee30 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-2932-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@sergio-teruel sergio-teruel sergio-teruel approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@chienandalu @pedrobaeza @OCA-git-bot @sergio-teruel