Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use unique paths for unresolved imports in bindings #1070

Merged

Conversation

OmarTawfik
Copy link
Collaborator

@OmarTawfik OmarTawfik commented Aug 10, 2024

So that two unresolved imports don't result in the same path.

cc @ggiraldez

@OmarTawfik OmarTawfik requested a review from a team as a code owner August 10, 2024 07:28
Copy link

changeset-bot bot commented Aug 10, 2024

⚠️ No Changeset found

Latest commit: 1354383

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@OmarTawfik OmarTawfik added this pull request to the merge queue Aug 12, 2024
Merged via the queue into NomicFoundation:main with commit cabf334 Aug 12, 2024
1 check passed
@OmarTawfik OmarTawfik deleted the incremental-resolve-path branch August 12, 2024 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants